Skip to content

Fix leaks from unprocessed user filter buckets #23267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthiasgoergens wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix leaks from unprocessed user filter buckets #23267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ PHP NEWS
is_writable(), is_readable(), is_executable(), is_file(), is_dir(),
is_link(), file_exists(), lstat(), stat(). (Girgias)

- Streams:
. Fixed memory leaks when a user stream filter returns PSFS_PASS_ON without
processing all input buckets. (Matthias Goergens)

30 Jul 2026, PHP 8.6.0alpha3

- Core:
Expand Down
2 changes: 0 additions & 2 deletions ext/standard/tests/filters/stream_filter_register_class_coerce_consumed_by_ref_param.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
--TEST--
stream_filter_register() with a class that coerces the $consumed parameter of filter method
--XFAIL--
This leaks memory
--FILE--
<?php

Expand Down
8 changes: 8 additions & 0 deletions ext/standard/tests/filters/stream_filter_register_filter_always_feed.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,18 @@ var_dump(stream_filter_append(STDOUT, "invalid_filter"));
$out = fwrite(STDOUT, "Hello\n");
var_dump($out);

$stream = fopen('data://text/plain,Hello', 'r');
var_dump(stream_filter_append($stream, "invalid_filter"));
var_dump(stream_get_contents($stream));

?>
--EXPECTF--
bool(true)
resource(4) of type (stream filter)

Warning: fwrite(): Unprocessed filter buckets remaining on input brigade in %s on line %d
int(0)
resource(%d) of type (stream filter)

Warning: stream_get_contents(): Unprocessed filter buckets remaining on input brigade in %s on line %d
string(0) ""
2 changes: 0 additions & 2 deletions ext/standard/tests/filters/stream_filter_register_mock_class_filter.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
--TEST--
stream_filter_register() with a class name exist that mocks php_user_filter with a filter method
--XFAIL--
This leaks memory
--FILE--
<?php

Expand Down
5 changes: 5 additions & 0 deletions ext/standard/user_filters.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,11 @@ static php_stream_filter_status_t userfilter_filter(

if (buckets_in->head) {
php_error_docref(NULL, E_WARNING, "Unprocessed filter buckets remaining on input brigade");
php_stream_bucket *bucket;
while ((bucket = buckets_in->head)) {
php_stream_bucket_unlink(bucket);
php_stream_bucket_delref(bucket);
}
}

/* filter resources are cleaned up by the stream destructor,
Expand Down
Loading