Fix GH-17773: Array element initialised by reference returned from a function - #23268
Open
matthiasgoergens wants to merge 3 commits into
Open
Fix GH-17773: Array element initialised by reference returned from a function#23268matthiasgoergens wants to merge 3 commits into
matthiasgoergens wants to merge 3 commits into
Conversation
zend_may_throw_ex() reported ZEND_MAKE_REF as non-throwing, but with ZEND_RETURNS_FUNCTION it raises an E_NOTICE that a userland error handler can turn into an exception. The JIT then emitted no exception check after calling the interpreter handler and continued with a corrupted instruction pointer, writing wild VM state.
When the exception escapes uncaught, ZEND_HANDLE_EXCEPTION frees the throwing opcode's result slot, which the handler had left uninitialised. Initialise it with ZVAL_UNDEF() so the unwinder sees a defined zval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialising an array element with a reference returned by a function, e.g.
[&foo()], is rejected at compile time although ordinary reference assignmentaccepts it. Allow user-function call results in this source position while
keeping the remaining source-side safeguards of reference assignment.