Fix GH-7781: CLI server prints HTML in startup warnings - #23269
Open
matthiasgoergens wants to merge 1 commit into
Open
Fix GH-7781: CLI server prints HTML in startup warnings#23269matthiasgoergens wants to merge 1 commit into
matthiasgoergens wants to merge 1 commit into
Conversation
devnexen
reviewed
Aug 14, 2026
| @@ -2907,7 +2870,12 @@ int do_cli_server(int argc, char **argv) /* {{{ */ | |||
| router = argv[php_optind]; | |||
| } | |||
|
|
|||
| if (FAILURE == php_cli_server_ctor(&server, server_bind_address, document_root, router)) { | |||
| /* Startup diagnostics are written to a terminal, not an HTTP response. */ | |||
| html_errors = PG(html_errors); | |||
Member
There was a problem hiding this comment.
why not acting on display_errors instead ? e.g.
...
uint8_t display_errors = PG(display_errors);
PG(display_errors) = 0;
/// note: php_cli_server_ctor() reports its own failures through php_cli_server_logf()
server_ctor_result = php_cli_server_ctor(&server, server_bind_address, document_root, router);
PG(display_errors) = display_errors;
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI server formats startup diagnostics with request-time HTML error
formatting, so resolver warnings show
<br>markup in the terminal. Temporarilydisable html_errors while constructing the server.