ext/uri: applied fixers to improve test robustness - #23271
Conversation
| @@ -9,7 +9,7 @@ var_dump(Uri\Rfc3986\Uri::parse("")); | |||
| try { | |||
| new Uri\WhatWg\Url(""); | |||
| } catch (Uri\WhatWg\InvalidUrlException $e) { | |||
There was a problem hiding this comment.
Will you want to catch Throwable? The current code makes review easier for now, but I guess the intention is to use Throwable ultimately, right?
There was a problem hiding this comment.
Generally the PR seeks to just assert what's currently thrown. If you want Throwable I can do it with a commit in here or send a follow up PR - which you prefer?
There was a problem hiding this comment.
I'm fine doing it here, thanks! :)
P.S These are "legacy" tests which should be moved into a more suitable place (one of the existing test subdirectories), and some of the tests are already replaced by newer tests in those subdirectories. The newer tests already use Throwable in the catch. :)
kocsismate
left a comment
kocsismate
left a comment
There was a problem hiding this comment.
LGTM especially if you change the catches to Throwable
2 participants
The one you didn't cherry pick (@ Tim); here without the style only lines. 🫡