Skip to content

Fix numeric color sorting in parcats bundles - #7959

Open
CAOShurong wants to merge 2 commits into
plotly:masterfrom
CAOShurong:codex/fix-parcats-numeric-bundle-sort
Open

Fix numeric color sorting in parcats bundles#7959
CAOShurong wants to merge 2 commits into
plotly:masterfrom
CAOShurong:codex/fix-parcats-numeric-bundle-sort

Conversation

@CAOShurong

Copy link
Copy Markdown

Closes #7952.

When bundlecolors is enabled, the parcats path sorter prepends each path's raw color to an array of category indices, then compares those arrays with JavaScript's < and > operators. That coerces the arrays to comma-separated strings, so numeric colors such as 1, 10, 2, 20 are ordered lexicographically.

This change compares the sort arrays element by element. Numeric colors now retain numeric order, while display-category indices and the existing value-index tie-breaker keep their current roles. A browser regression test renders a bundled parcats trace and checks the resulting path view-model order.

Verification:

  • npm run lint — passed (2,479 files)
  • npm run cibuild — passed
  • npm run test-jasmine -- parcats --nowatch --report-spec — the new regression passed; the run had 27 successes and the same four pre-existing Chrome 151/Windows drag-callback failures reproduced before the implementation
  • npm run test-bundle — 10 bundle suites passed; the unrelated MathJax v2 config suite timed out on Chrome 151/Windows

The repository does not define a type-check script. The Windows test-syntax and full build commands also hit an existing glob portability problem (0 source files found), so I am relying on the successful CI build above and the repository's hosted CI for those Linux gates.

AI assistance disclosure: This contribution was developed and tested with OpenAI Codex. The implementation, regression coverage, and observed command results are disclosed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: bundlecolors in parallel_categories plot (Parcats) sort numerical values out of order

2 participants