gh-155694: Scope HTTPPasswordMgr credentials by URL scheme - #155696
Open
lkk7 wants to merge 2 commits into
Open
Conversation
Documentation build overview
12 files changed ·
|
sethmlarson
reviewed
Aug 14, 2026
| return (scheme or None, *self.reduce_uri(uri, default_port)) | ||
|
|
||
| def _is_suburi_with_scheme(self, base, test): | ||
| if (base[0] is not None and test[0] is not None and |
Contributor
There was a problem hiding this comment.
This only compares the scheme if both are non-None, is that correct? Or should it check the scheme regardless of whether each is None?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155694.
Scope HTTPPasswordMgr credentials by URL scheme. This prevents a situation where credentials stored for an HTTPS URL match a corresponding HTTP URL. URIs without a scheme will still match any scheme.
HTTPPasswordMgrcan send saved HTTPS credentials via HTTP because of incorrect scheme matching #155694