gh-155733: Validate keyword argument keys in operator.methodcaller and functools.partial - #155779
Open
pranavchoudhary-tech wants to merge 3 commits into
Open
gh-155733: Validate keyword argument keys in operator.methodcaller and functools.partial#155779pranavchoudhary-tech wants to merge 3 commits into
pranavchoudhary-tech wants to merge 3 commits into
Conversation
…s-155733 # Conflicts: # Modules/_functoolsmodule.c
Contributor
|
I think there are some cases that you are missing (like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-155733: Validate keyword argument keys in
operator.methodcallerandfunctools.partialSummary
Fixes gh-155733.
Previously, passing non-string keys as
**kwargsintooperator.methodcallerorfunctools.partialbypassed kwarg type validation, leading to vectorcall assertion failures (PyUnicode_Check) or segmentation faults in CPython.This PR adds keyword type checks (
PyUnicode_Check) tomethodcaller_new,partial_new, andpartial_vectorcall, raisingTypeError: keywords must be stringscleanly.