gh-155781: Hold strong references to sqlite3 converters - #155784
Open
cuishuang wants to merge 1 commit into
Open
gh-155781: Hold strong references to sqlite3 converters#155784cuishuang wants to merge 1 commit into
cuishuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
PyDict_GetItemRef()when looking up registered SQLite converters so the converter remains alive until it has been added to the cursor's row cast map.Update the caller's reference ownership and add a free-threading regression test that concurrently builds row cast maps and modifies the public converter registry.
Tests:
./python -m test -v test_free_threading.test_sqlite3./python -m test -v test_sqlite3make patchcheck