Add guards for react/renderer/components/view (#57357) (#57357) (#57357) - #57357
Open
coado wants to merge 3 commits into
Open
Add guards for react/renderer/components/view (#57357) (#57357) (#57357)#57357coado wants to merge 3 commits into
coado wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109847184. |
coado
added a commit
to coado/react-native
that referenced
this pull request
Jun 29, 2026
Summary: Pull Request resolved: react#57357 Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Differential Revision: D109847184
meta-codesync
Bot
changed the title
coado
added a commit
to coado/react-native
that referenced
this pull request
Jun 29, 2026
Summary: Pull Request resolved: react#57357 Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Differential Revision: D109847184
coado
added a commit
to coado/react-native
that referenced
this pull request
Jun 29, 2026
Summary: Pull Request resolved: react#57357 Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Differential Revision: D109847184
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 7, 2026
Summary: Pull Request resolved: react#57357 Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Differential Revision: D109847184
coado
force-pushed
the
export-D109847184
branch
2 times, most recently
from
August 10, 2026 10:38
7db213d to
9353807
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 10, 2026
Summary: Pull Request resolved: react#57357 Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Differential Revision: D109847184
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 11, 2026
Summary: Pull Request resolved: react#57357 Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Differential Revision: D109847184
coado
force-pushed
the
export-D109847184
branch
from
August 11, 2026 12:02
9353807 to
dd63424
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 11, 2026
Summary: Pull Request resolved: react#57357 Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Differential Revision: D109847184
coado
force-pushed
the
export-D109847184
branch
from
August 11, 2026 12:07
dd63424 to
4098227
Compare
|
@coado has imported this pull request. If you are a Meta employee, you can view this in D109847184. |
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D109847184
branch
from
August 12, 2026 12:24
68a4ab7 to
b7ed0e1
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 12, 2026
) Summary: Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Pull Request resolved: react#57357 Differential Revision: D109847184 Pulled By: coado
…rgets (react#57861) Summary: Pull Request resolved: react#57861 React Native's public C++ headers are gaining guards from `react/cxxstableapi`, which turn a direct include of a fine-grained header into an error for consumers that opt into the strict API by defining `RN_STRICT_API`. React Native's own sources keep including those headers directly, so they are exempted via `RN_BUILDING`. Unlike CocoaPods, these three build systems each have a single chokepoint: - CMake: one `add_compile_definitions(RN_BUILDING)` in the ReactAndroid JNI project, a directory property inherited by every `add_react_common_subdir` below it. It is declared *after* the third-party NDK subdirectories so glog/boost/folly/fmt never see it, and this project never compiles app or third-party module code. - SwiftPM: one `.define` in the shared `Target.reactNativeTarget` factory that every React Native target is created through. `cxxSettings` are per-target and are not inherited by packages that depend on React. - Buck: a `_set_rn_building_flag` helper called from the four macros React Native's own targets use. It is `preprocessor_flags`, deliberately not `exported_preprocessor_flags`, so dependents are not exempted either. This change is inert on its own: nothing behaves differently unless a consumer defines `RN_STRICT_API`. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D115051088
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 13, 2026
) (react#57357) Summary: Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Pulled By: coado Pull Request resolved: react#57357 coado Reviewed By: cipolleschi Differential Revision: D109847184
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D109847184
branch
from
August 13, 2026 10:00
435e9e1 to
34af97e
Compare
Summary: `react/cxxstableapi` is a header-only module — the stable API guards are pure preprocessor headers with no compilable source. Under `use_frameworks!`, CocoaPods emits a `PBXAggregateTarget` for a pod with no compilable sources, and an aggregate target produces no `.framework`, so pods depending on `React-cxxstableapi` cannot resolve the guard headers. Add an anchor translation unit so the pod has one source and CocoaPods emits a real framework target instead, and widen the podspec's build-from-source glob to pick it up. The prebuilt glob stays headers-only, since prebuilt pods do not generate frameworks. This mirrors the existing `CSSDummy.cpp` anchor for the header-only `React-renderercss` pod. Also register `react/cxxstableapi` as a subdirectory of the Fantom tester CMake build so the guard headers resolve there. Changelog: [Internal] Differential Revision: D115859623
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 13, 2026
) (react#57357) Summary: Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Pulled By: coado Pull Request resolved: react#57357 coado Reviewed By: cipolleschi Differential Revision: D109847184
coado
force-pushed
the
export-D109847184
branch
from
August 13, 2026 10:59
34af97e to
f0f1265
Compare
) (react#57357) Summary: Roll umbrella with umbrella guards for headers under `react/renderer/components/view` subtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard. Changelog: [Internal] Pulled By: coado Pull Request resolved: react#57357 coado Reviewed By: cipolleschi Differential Revision: D109847184
coado
force-pushed
the
export-D109847184
branch
from
August 13, 2026 12:33
f0f1265 to
6b102b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Roll umbrella with umbrella guards for headers under
react/renderer/components/viewsubtree. Initially, we assume that the entire target is public, so each header within includes a public umbrella guard.Changelog:
[Internal]
Pulled By:
coado
coado
Reviewed By: cipolleschi
Differential Revision: D109847184