Skip to content

Make BabelNode* types module-local within @babel/types (remove ambient globals) (#57866) - #57866

Closed
robhogan wants to merge 1 commit into
mainfrom
export-D114881982
Closed

Make BabelNode* types module-local within @babel/types (remove ambient globals) (#57866)#57866
robhogan wants to merge 1 commit into
mainfrom
export-D114881982

Conversation

@robhogan

@robhogan robhogan commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary:

Now that all internal and OSS Babel types use explicitly imported types (see stack), modify our Babel type generator scripts and the generated lib defs so that they no longer declare global types.

This unblocks migrating to a modern flowtyped declaration and removing the .flowconfig coupling.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D114881982

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2026
@facebook-github-tools facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels Aug 8, 2026
@meta-codesync

meta-codesync Bot commented Aug 8, 2026

Copy link
Copy Markdown

@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114881982.

@meta-codesync meta-codesync Bot changed the title Make BabelNode* types module-local within @babel/types (remove ambient globals) Make BabelNode* types module-local within @babel/types (remove ambient globals) (#57866) Aug 11, 2026
meta-codesync Bot pushed a commit that referenced this pull request Aug 11, 2026
…ent globals) (#57866)

Summary:

Now that all internal and OSS Babel types use explicitly imported types (see stack), modify our Babel type generator scripts and the generated lib defs so that they no longer declare global types.

This unblocks migrating to a modern `flowtyped` declaration and removing the `.flowconfig` coupling.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D114881982
@meta-codesync
meta-codesync Bot force-pushed the export-D114881982 branch from 4bf5015 to ef045a7 Compare August 11, 2026 13:19
meta-codesync Bot pushed a commit that referenced this pull request Aug 11, 2026
…ent globals) (#57866)

Summary:

Now that all internal and OSS Babel types use explicitly imported types (see stack), modify our Babel type generator scripts and the generated lib defs so that they no longer declare global types.

This unblocks migrating to a modern `flowtyped` declaration and removing the `.flowconfig` coupling.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D114881982
@meta-codesync
meta-codesync Bot force-pushed the export-D114881982 branch from ef045a7 to 2ff5f30 Compare August 11, 2026 15:59
meta-codesync Bot pushed a commit that referenced this pull request Aug 12, 2026
…ent globals) (#57866)

Summary:

Now that all internal and OSS Babel types use explicitly imported types (see stack), modify our Babel type generator scripts and the generated lib defs so that they no longer declare global types.

This unblocks migrating to a modern `flowtyped` declaration and removing the `.flowconfig` coupling.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D114881982
@meta-codesync
meta-codesync Bot force-pushed the export-D114881982 branch from 2ff5f30 to 1e9b591 Compare August 12, 2026 14:51
…ent globals) (#57866)

Summary:

Now that all internal and OSS Babel types use explicitly imported types (see stack), modify our Babel type generator scripts and the generated lib defs so that they no longer declare global types.

This unblocks migrating to a modern `flowtyped` declaration and removing the `.flowconfig` coupling.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D114881982
@meta-codesync
meta-codesync Bot force-pushed the export-D114881982 branch from 1e9b591 to 0f9ce7b Compare August 13, 2026 11:24
meta-codesync Bot pushed a commit to react/metro that referenced this pull request Aug 13, 2026
…ent globals)

Summary:
X-link: react/react-native#57866

Now that all internal and OSS Babel types use explicitly imported types (see stack), modify our Babel type generator scripts and the generated lib defs so that they no longer declare global types.

This unblocks migrating to a modern `flowtyped` declaration and removing the `.flowconfig` coupling.

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D114881982

fbshipit-source-id: df29b8e22cf070f2e39c994f3a0856be4939fdc9
@meta-codesync meta-codesync Bot closed this in 2b995be Aug 13, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Aug 13, 2026
@meta-codesync

meta-codesync Bot commented Aug 13, 2026

Copy link
Copy Markdown

This pull request has been merged in 2b995be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant