Format affected files with clang-format - #57902
Open
matinzd wants to merge 3 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
matinzd
marked this pull request as ready for review
August 11, 2026 21:01
matinzd
commented
Aug 11, 2026
Contributor
Author
There was a problem hiding this comment.
SHA of squashed commit can be added here after merging.
matinzd
changed the title
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Not sure if this is the best approach, but I think we should either update
yarn formatto use only Prettier, or fix non formatted files.If we decide to proceed with fixing
clang-format, we can avoid the impact ongit blamehistory by using.git-blame-ignore-revs. However merge conflicts can happen 👀 . After this PR is merged, we can add the SHA of the squash merge commit to that file so these formatting-only changes are excluded fromgit blame.Otherwise feel free close this PR and remove
clang-formatfromformatscript.Changelog:
[Internal] [Changed] - Apply
clang-formatto consistently format the affected files.Test Plan:
yarn format