Improves spm deintegrate script to handle more edge-cases - #57930
Open
ospfranco wants to merge 1 commit into
Open
Improves spm deintegrate script to handle more edge-cases#57930ospfranco wants to merge 1 commit into
ospfranco wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
ospfranco
commented
Aug 12, 2026
| // Run `pod deintegrate` then strip React Native from the Podfile (leaving any | ||
| // non-RN pods). Requires CocoaPods on PATH (fail-loud otherwise). Flag-gated ⇒ | ||
| // no prompt ⇒ CI-safe. Does NOT touch the .xcworkspace. | ||
| // no prompt ⇒ CI-safe. |
Contributor
Author
There was a problem hiding this comment.
Does slightly touch the .xcworkspace to remove the dangling reference :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The SPM deintegrate script can fail in subtle ways on certain edge cases. This PR aims to improve:
automaticPodsInstallationin the host app react-native.config.js, without this pods gets re-installed and the SPM project fails.xcworkspacedoes not get completely cleared of the Pods project, leaving a dangling referenceChangelog:
[IOS] [FIXED] - Fixes various edge-case failures with the spm deintegrate script
Test Plan:
Tests have been added for each of the described edge-cases. For disclosure: this is mostly an AI PR, I just guided claude through the necessary changes.