fix(docs): preserve dashboard dialog validation - #6875
Open
rohit-jsfreaky wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThe documentation examples now control dashboard dialog visibility through Reflex state so invalid required forms remain open and successful submissions close the dialog.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| docs/getting_started/dashboard_tutorial.md | Updates all dashboard tutorial variants to use controlled dialog state and close only after successful form submission. |
Reviews (2): Last reviewed commit: "fix(docs): preserve dialog validation in..." | Re-trigger Greptile
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
rohit-jsfreaky
force-pushed
the
fix/dashboard-dialog-validation
branch
from
August 12, 2026 08:51
0b8a1ff to
321ed07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6816
Summary
The dashboard tutorial wraps its Submit button in
rx.dialog.close, so clicking it closes the dialog before the browser can keep an invalid required form open.This makes each executable dashboard example use controlled dialog state. The form's submit handler closes the dialog only after a valid submission has reached
add_user. The Cancel control remains a normalrx.dialog.closeaction.Behavior
on_open_change.Validation
uv run reflex compilefromdocs/apppassed.uv run pytest "docs/app/tests/test_docgen_double_eval.py::test_double_eval_all_docs[docs/getting_started/dashboard_tutorial.md]"passed.uv run pre-commit run --files docs/getting_started/dashboard_tutorial.mdpassed.uv run ruff check .passed.uv run pyright reflex testspassed with 0 errors.Full suite note
uv run pytest tests/units --cov --no-cov-on-fail --cov-report=completed with 7,030 passing tests and 140 unrelated failures in cloud/CLI and telemetry tests on this Windows/Python 3.14 environment. The changed dashboard tutorial docgen case passes.Submission checklist
CONTRIBUTING.md.