Stop tools tests on unexpected failures - #8545
Merged
cknitt merged 1 commit intoAug 13, 2026
Merged
Conversation
Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
marked this pull request as ready for review
August 13, 2026 11:44
| ../../_build/install/default/bin/rescript-tools doc $file > $output | ||
| # # CI. We use LF, and the CI OCaml fork prints CRLF. Convert. | ||
| if [ "$RUNNER_OS" == "Windows" ]; then | ||
| if [ "${RUNNER_OS:-}" == "Windows" ]; then |
fhammerschmidt
approved these changes
Aug 13, 2026
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format-codeblocksandextract-codeblocksRUNNER_OSis unsetWhy
The invalid docstring fixture correctly makes the tools commands exit with a non-zero status. The test script previously ignored those statuses and continued, so
make test-allprinted a prominent syntax error while still treating the tools suite as successful. The same behavior could also hide genuinely unexpected command failures.The negative fixture is now asserted explicitly: the suite fails if either command unexpectedly succeeds, while all other failures stop the script immediately.
Testing
FormatDocstringsTestError.resand produce the checked-in expected outputmake -C tests/tools_tests testbash -n tests/tools_tests/test.sh