Skip to content

Use stable ReScript versions in Rewatch tests - #8546

Merged
cknitt merged 1 commit into
rescript-lang:masterfrom
cknitt:codex/update-rewatch-fixture-versions
Aug 13, 2026
Merged

Use stable ReScript versions in Rewatch tests#8546
cknitt merged 1 commit into
rescript-lang:masterfrom
cknitt:codex/update-rewatch-fixture-versions

Conversation

@cknitt

@cknitt cknitt commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Update the root Rewatch test fixture from ReScript 12.0.0-beta.1 to 12.0.0.
  • Update the nested non-hoisted fixture from 12.0.0-beta.3 to 12.3.0.
  • Regenerate the fixture lockfile while preserving separate root and nested installations.
  • Document why the test uses distinct published versions and how compilation still uses repository-built artifacts.

Why

The prerelease versions were historical pins rather than compatibility requirements. Using two distinct stable versions preserves coverage for hoisted and non-hoisted dependency discovery while removing obsolete beta dependencies.

The added documentation clarifies that these packages model a realistic dependency tree; the compiler and runtime under test are built from the current repository.

Validation

  • yarn install --immutable in rewatch/testrepo
  • yarn why rescript confirms ReScript 12.0.0 at the root and 12.3.0 in the nested workspace
  • Rewatch compilation tests passed; the sandbox prevented the later watch-process cleanup check

Signed-off-by: Christoph Knittel <ck@cca.io>
@pkg-pr-new

pkg-pr-new Bot commented Aug 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8546

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8546

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8546

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8546

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8546

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8546

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8546

commit: 9299b3a

@cknitt
cknitt marked this pull request as ready for review August 13, 2026 13:15
@cknitt
cknitt requested a review from fhammerschmidt August 13, 2026 13:15
@cknitt
cknitt merged commit 11a25f4 into rescript-lang:master Aug 13, 2026
53 of 54 checks passed
@cknitt
cknitt deleted the codex/update-rewatch-fixture-versions branch August 13, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants