ux: improve checkbox contrast in dark theme - #2622
Open
a2580vb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve checkbox contrast in dark theme.
Changes
1.
src/Resources/Themes.axamlAdded checkbox-specific resources to both Light and Dark theme dictionaries:
Color.CheckBox.Border: Set to#898989(same as Border1) in the Light theme, and#A8A8A8(a brighter border for better visibility) in the Dark theme.Brush.CheckBox.CheckedBackground: RemainsTransparentin the Light theme, while using the system accent color in the Dark theme.Brush.CheckBox.CheckedBorder: Remains#898989in the Light theme, while using the system accent color in the Dark theme.Brush.CheckBox.CheckedFG: Uses the system accent color (unchanged) in the Light theme, and white in the Dark theme.Additionally,
Color.CheckBox.Borderis registered as theBrush.CheckBox.Borderbrush in the shared section, and the three checked-state brushes are defined directly asSolidColorBrushinstances within each theme dictionary.2.
src/Resources/Styles.axamlBrush.Border1toBrush.CheckBox.Border.^:checked: Uses themed background and border brushes when checked.Fillchanged from the template defaultBrush.AccenttoBrush.CheckBox.CheckedFG.:focus-visible:checkedstyle updated to use the same themed resources.Result