Fix TeamDynamix auth scripting config - #112
Conversation
Document that `showScripting` must be enabled whenever `preRequestScript` is used, because otherwise the platform silently skips the script and requests go unauthenticated. Update the TeamDynamix plugin metadata to set `showScripting: true` alongside its scripting variables so the JWT pre-request script executes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe TeamDynamix plugin now enables WebAPI scripting and reports version ChangesTeamDynamix scripting configuration
Mergeability Score: ⚪ Minimal · up to This localized configuration and documentation update enables the TeamDynamix authorization script without introducing a supported merge-blocking concern; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
🔍 Validation Details✅
|
📋 Summary
This PR fixes a bug where the TeamDynamix plugin never sent an
Authorizationheader, so every request to a customer's portal came back 401.The plugin sets
preRequestScriptto do the BEID / Web Services Key token exchange, but notshowScripting, which defaults tofalse. When that flag is falsy the WebAPI base plugin discards the script before running it, with no error and no warning, so the plugin looks correctly wired while sending unauthenticated requests. In the manual WebAPI data sourceshowScriptingis the "Pre-request script" toggle a user ticks, and a declarative plugin has no one to tick it, so it has to set the flag itself. I've set it totrueand bumped the plugin to 1.0.2.I've also added the flag to the build-plugin skill's pre-request section, which covered
scriptingVariablesandpreRequestScriptbut never mentionedshowScripting. Anyone following that guidance ends up with the same silent failure.To verify, run any data stream against a configured TeamDynamix data source (for example Tickets): before this change every request comes back 401, after it the token exchange runs and the stream returns rows. I haven't been able to test against a live portal, so this is verified against how the platform handles
showScriptingrather than end to end, and it's worth a reviewer with portal access confirming before it goes out.🧩 Plugin details
Does this PR introduce any breaking changes?
📚 Documentation
✅ Checklist
Summary by CodeRabbit
New Features
Documentation