chore: remove obsolete v3/v4 version copy from the dashboard - #4589
chore: remove obsolete v3/v4 version copy from the dashboard#4589claude[bot] wants to merge 4 commits into
Conversation
Engine V1 (v3) execution has been removed, so every "you need V4 for this" notice in the dashboard decorated a feature that is already available to everyone, and the side menu's v3 deprecation panel advertised shutdown dates that have now passed. Removes the V4Badge/V4Title component and its call sites, the "branches require V4" copy in the environment selector and both blank-state panels, the V3 deprecation panel in the side menu, and the queues-page engine-version upgrade callout along with the presenter code paths that produced it. Co-Authored-By: Claude <noreply@anthropic.com>
|
The dashboard-side cleanup dropped the engine-version failure arm from the queue presenters, which also removed the 400 that GET /api/v1/queues and GET /api/v1/queues/:queueParam returned for engine V1 projects. Restore that rejection in the two API route handlers so v3 clients still get a clean 4xx, while the dashboard keeps the simplified presenter result and page. Co-Authored-By: Claude <noreply@anthropic.com>
Restore the BookOpenIcon and docsPath imports in the queues route. This branch removed them along with the obsolete v3 upgrade callout, while main's #4592 added new WhenAgentUnavailable docs buttons that use both. The textual merge was clean but left the file referencing two unimported symbols. Co-Authored-By: Claude <noreply@anthropic.com>
Restore the allowArbitraryQueues flag on the test-task and replay paths. The queue dropdown is fed by a query that hard-filters version "V2", so a V1 environment sees an empty list; the free-text input is the only way those users can set a queue. Removing it was a functional regression and out of scope for a copy cleanup. Also drop QueuesHasNoTasks, which lost its only renderer along with the V1 queues failure UI, and the now-unreferenced queues-dashboard.png asset. Co-Authored-By: Claude <noreply@anthropic.com>
| /> | ||
| {environment.type === "DEVELOPMENT" && project.engine === "V2" && ( | ||
| {environment.type === "DEVELOPMENT" && ( |
There was a problem hiding this comment.
🔍 allowArbitraryQueues cleanup claimed in the description was not actually made
The PR description says the engine === "V1" → allowArbitraryQueues derivations and their plumbing through the test-task forms and ReplayRunDialog are gone, but they still exist: apps/webapp/app/presenters/v3/TestTaskPresenter.server.ts:238, apps/webapp/app/routes/resources.taskruns.$runParam.replay.ts:165, and the consumers in apps/webapp/app/components/runs/v3/ReplayRunDialog.tsx:391 and the test-task route. Either the description is stale or part of the intended change was dropped before pushing — worth confirming which.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
The derivations are retained deliberately: the queue dropdown is fed by QueueListPresenter, which hard-filters version: "V2" (apps/webapp/app/presenters/v3/QueueListPresenter.server.ts:73), so on an engine V1 environment the Select would come back empty and the free-text Input behind allowArbitraryQueues is the only way to set a queue at all — TestTaskPresenter.server.ts, resources.taskruns.$runParam.replay.ts, ReplayRunDialog.tsx and the test-task route are all at zero diff against main on this head. The description was already corrected before this review landed; its ## Scope section now states that those two paths are untouched and explains why the earlier removal was wrong.
Generated by Claude Code
Requested by Chris Arderne · Slack thread
✅ Checklist
Before / after
Engine V1 (v3) execution is gone, so every "you need V4 for this" notice in the dashboard was decorating a feature that everyone already has.
Before
After
None of the above appears. The branch panels keep the sentence that explains what branches are and drop the version claim; the panel whose real gate is the plan lets its title and Upgrade button carry that on their own, rather than asserting a second, wrong reason. Page titles are plain text. The side menu ends at the incident panel. The queues page always renders the queues table.
Scope
This is copy removal plus the dead code that removal leaves behind. The test-task and replay forms are not touched. An earlier revision of this branch also deleted the
allowArbitraryQueuesflag those two paths use to swap the queueSelectfor a free-textInput. That was wrong: the dropdown is fed by a query that hard-filtersversion: "V2", so on an engine V1 environment the list comes back empty and the free-text input is the only way to set a queue at all. Both paths keep their existing behaviour, andTestTaskPresenter.server.ts,resources.taskruns.$runParam.replay.ts,ReplayRunDialog.tsxand the test-task route are back to zero diff againstmain.How
apps/webapp/app/components/V4Badge.tsx(V4Badge+V4Title) and unwrapped its call sites inwaitpoints.tokens,branches(two arms) anddev-branchesroutes so each is a plain<PageTitle title="…" />.components/navigation/EnvironmentSelector.tsxand both panels incomponents/BlankStatePanels.tsx, plus the imports that went with it.V3DeprecationPanel,V3DeprecationContent,isV3Project,V4_RELEASE_DATE,isLikelyV3and the mount site fromcomponents/navigation/SideMenu.tsx, and droppedengine/createdAtfromSideMenuProjectnow that nothing reads them.EngineVersionUpgradeCalloutand bothcode === "engine-version"call sites from the queues route. That took the last reference toassets/images/queues-dashboard.pngwith it, so the screenshot is deleted too, along withQueuesHasNoTasksinBlankStatePanels.tsx— the removed failure UI was its only renderer, and it is unreachable without it.code: "engine-version"producers fromQueueListPresenter.server.tsandQueueRetrievePresenter.server.ts, and moved that check up into the two API route handlers.GET /api/v1/queuesandGET /api/v1/queues/:queueParamstill calldetermineEngineVersionand still answer an engine V1 project with400 {"error": "engine-version"}, unchanged — that is a reachable clean-4xx path for clients still on v3, and only the dashboard's rendering of it was removed. InQueueRetrievePresenterthequeue-not-foundfailure arm survives, soapi.v1.queues.$queueParam.tsreturns the 400 before the presenter runs and maps the presenter's one remaining failure to 404. InQueueListPresenterengine-versionwas the onlysuccess: falseproducer, so with the check hoisted the result type collapses to a single object shape;api.v1.queues.ts, the queues resource route, the runs AI-filter route and the queues page were updated to match.project.engine === "V2"guards that engine V1's removal made constant, in the runs index route and the side menu.None of these are part of the deprecation boundary described in
.claude/rules/legacy-v3-code.md— they are display affordances, not reject-cleanly paths. The V1 branches inengineDeprecation.server.ts,engineVersion.server.ts,triggerTask.server.ts,cancelTaskRun.server.ts,rescheduleTaskRun.server.ts,initializeDeployment.server.tsandhandleWebsockets.server.tsare untouched, as are the historical-data paths inSpanPresenter,ApiRetrieveRunPresenter,replayTaskRunand the admin debug views.Left for follow-up
Deliberately out of scope here:
docsPath("v3/…")link targets (tasks.scheduled.$taskParam,schedules.new,test.tasks.$taskParam,tasks.dashboard,components/runs/v3/TaskRunsTable.tsx,BlankStatePanels). They resolve, but via two redirect hops.batchVersion === "v1"tooltip on the batches page, "Upgrade to the latest SDK for batch statuses to appear." The gate is live legacy data, but the advice is stale — a v1 batch is a historical record that upgrading cannot fix. That is a rewording, not a removal.@trigger.dev/sdk/v3warning inSetupCommands.tsx, which is still useful guidance inside an agent-rules prompt."Beta upgrade guide"onOUTDATED_SDK_VERSIONinpackages/core— stale branding rather than a v3/v4 specifier, and it would turn this into a mixed PR.One thing noticed while working that was not in scope:
WaitpointListPresenter.server.tsstill returns"Upgrade to SDK version 4+ to use Waitpoint tokens."behind anengineVersion === "V1"check — the same shape as the queues callout removed here, worth the same treatment.pauseQueue.server.tskeeps itscode: "engine-version"rejection, and so do the two queues API endpoints — that is API behaviour on the clean-4xx boundary, not dashboard copy.Testing
pnpm run typecheck --filter webapppasses, andpnpm run lintis clean afterpnpm run format/pnpm run lint:fix. Not exercised in a running dashboard.Changelog
Out-of-date upgrade prompts no longer appear in the dashboard: the "V4" badges, the notices saying preview branches and the queues table need V4, and the v3 deprecation warning in the side menu have all been removed.