fix(webapp): show the dev environment's actual limit in the concurrency page Total column - #4596
fix(webapp): show the dev environment's actual limit in the concurrency page Total column#4596matt-aitken wants to merge 1 commit into
Conversation
…cy page Total column The Total cell summed the plan's included concurrency with the extra concurrency allocation, but dev environments are excluded from the allocation map, so the dev row always rendered the plan default even when the environment's limit had been raised.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (20)
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the change and root cause but omits the required issue, checklist, testing, changelog, and screenshots sections. | Add the required template sections and provide testing details, changelog text, screenshots, checklist status, and an issue reference. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely describes the main change to the dev environment concurrency Total column. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Create stacked PR
- Commit on current branch
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/dev-concurrency-total-display
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Summary
On the Concurrency page, the dev environment row's Total always showed the plan's included dev concurrency, even when the environment's limit had been raised. The row's own "Extra concurrency" value was already derived from the real limit, so the two columns could disagree with each other.
Root cause
The Total cell renders
planConcurrencyLimit + allocation, whereallocationis the state behind the editable prod/staging inputs. Dev environments are deliberately excluded from that allocation map (dev concurrency is not purchasable), so the dev row's allocation always resolved to 0 and the Total fell back to the plan value. The dev row now renders the environment's actualmaximumConcurrencyLimitinstead.