refactor(fspy-nostd-alloc): rename arena to pooled_bump - #672
Draft
wan9chi wants to merge 1 commit into
Draft
Conversation
fspy benchmarklinuxmacoswindows |
The crate is infrastructure and should name its exports after their mechanism, not after how its consumers happen to use them: arena() is a bump allocator backed by the process-wide chunk pool, so call it pooled_bump() and its settings PooledBumpSettings. The crate docs now describe the three layers in the same mechanism-first terms. pooled_bump() also returns impl BumpAllocator + Allocator instead of impl Allocator, with the bump-scope trait re-exported: callers get the bump interface (scopes, resets) without a direct bump-scope dependency, not just an anonymous allocator. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
wan9chi
force-pushed
the
agent/fspy-pooled-bump-rename
branch
from
August 14, 2026 08:04
bc86aab to
a21bce3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fspy_nostd_allocis infrastructure: it should name its exports after their mechanism, not after how its consumers happen to use them.arena()is a bump allocator backed by the process-wide chunk pool, so this renames it topooled_bump()(andArenaSettingstoPooledBumpSettings), and rewrites the crate docs in the same mechanism-first terms.pooled_bump()now also returnsimpl BumpAllocator + Allocatorinstead ofimpl Allocator, with the bump-scope trait re-exported: callers get the bump interface (scopes, resets) rather than an anonymous allocator, without taking a direct bump-scope dependency. Groundwork for the payload-view PR on top of this stack, which adds a page-backed sibling with the same signature.🤖 Generated with Claude Code