image.c: mldsa: don't discard return value - #856
Open
rizlik wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts ML-DSA signature verification in src/image.c to properly handle and propagate error states (avoiding use of an uninitialized key and ensuring return values are not effectively ignored) during wolfCrypt ML-DSA key setup.
Changes:
- Adds an early return when
wc_MlDsaKey_Init()fails (preventing subsequent operations on an uninitializedwc_MlDsaKey). - Makes ML-DSA wolfHSM key-ID setup conditional on prior success (
ret == 0) after parameter configuration. - Simplifies control flow by removing a redundant
if (ret == 0)wrapper aroundwc_MlDsaKey_SetParams().
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
820
to
824
| if (ret != 0) { | ||
| /* Failed to initialize key, nothing to free */ | ||
| wolfBoot_printf("error: wc_MlDsaKey_Init returned %d\n", ret); | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-7968