Regression testing fixes: TLS1.3 and Aarch64 AES-GCM guards - #11164
Open
SparkiDev wants to merge 1 commit into
Open
Regression testing fixes: TLS1.3 and Aarch64 AES-GCM guards#11164SparkiDev wants to merge 1 commit into
SparkiDev wants to merge 1 commit into
Conversation
tls1.3: fix guard SendTls13CertificateVerify: ML-DSA sig size, and signing, only available when compiled when WOLFSSL_MLDSA_NO_SIGN is not defined. AArch64 AES-GCM: fix decrypt guards Have decrypt guards for AES-GCM assembly code for AArch64.
Contributor
Author
|
Code generated with PR: |
Contributor
Author
|
Jenkins: retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tls1.3: fix guard
SendTls13CertificateVerify: ML-DSA sig size, and signing, only available when compiled when WOLFSSL_MLDSA_NO_SIGN is not defined.
AArch64 AES-GCM: fix decrypt guards
Have decrypt guards for AES-GCM assembly code for AArch64.
Testing
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm --enable-aescbc --enable-aesofb --enable-aescfb --enable-aesgcm --enable-aesgcm-stream --enable-aesccm --enable-aesctr --enable-aesxts --enable-aeseax
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm --enable-aescbc --enable-aesofb --enable-aescfb --enable-aesgcm --enable-aesgcm-stream --enable-aesccm --enable-aesctr --enable-aesxts --enable-aeseax CFLAGS=-DNO_AES_DECRYPT
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=inline --enable-aescbc --enable-aesofb --enable-aescfb --enable-aesgcm --enable-aesgcm-stream --enable-aesccm --enable-aesctr --enable-aesxts --enable-aeseax
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=inline --enable-aescbc --enable-aesofb --enable-aescfb --enable-aesgcm --enable-aesgcm-stream --enable-aesccm --enable-aesctr --enable-aesxts --enable-aeseax CFLAGS=-DNO_AES_DECRYPT
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=sha3-crypto --enable-aescbc --enable-aesofb --enable-aescfb --enable-aesgcm --enable-aesgcm-stream --enable-aesccm --enable-aesctr --enable-aesxts --enable-aeseax
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=sha3-crypto --enable-aescbc --enable-aesofb --enable-aescfb --enable-aesgcm --enable-aesgcm-stream --enable-aesccm --enable-aesctr --enable-aesxts --enable-aeseax CFLAGS=-DNO_AES_DECRYPT
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=inline,sha3-crypto --enable-aescbc --enable-aesofb --enable-aescfb --enable-aesgcm --enable-aesgcm-stream --enable-aesccm --enable-aesctr --enable-aesxts --enable-aeseax
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=inline,sha3-crypto --enable-aescbc --enable-aesofb --enable-aescfb --enable-aesgcm --enable-aesgcm-stream --enable-aesccm --enable-aesctr --enable-aesxts --enable-aeseax CFLAGS=-DNO_AES_DECRYPT
One-shot guard in isolation, plus the GCM-off negative control:
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm --enable-aesgcm
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm --enable-aesgcm CFLAGS=-DNO_AES_DECRYPT
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm --disable-aesgcm CFLAGS=-DNO_AES_DECRYPT
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=inline --enable-aesgcm
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=inline --enable-aesgcm CFLAGS=-DNO_AES_DECRYPT
./configure --disable-shared --enable-cryptonly --host=aarch64 CC=aarch64-linux-gnu-gcc LDFLAGS=--static --enable-armasm=inline --disable-aesgcm CFLAGS=-DNO_AES_DECRYPT
./configure --disable-shared --disable-asm --disable-sp-asm --enable-mldsa=make,44,65,87
./configure --disable-shared --disable-asm --disable-sp-asm --enable-mldsa=make,44
./configure --disable-shared --disable-asm --disable-sp-asm --enable-mldsa=make,44,65
./configure --disable-shared --disable-asm --disable-sp-asm --enable-mldsa=make,44,87
./configure --disable-shared --disable-asm --disable-sp-asm --enable-mldsa=make,65
./configure --disable-shared --disable-asm --disable-sp-asm --enable-mldsa=make,65,87
./configure --disable-shared --disable-asm --disable-sp-asm --enable-mldsa=make,87
./configure --disable-shared --disable-asm --disable-sp-asm --enable-mldsa