Skip to content

Pin tutorial pack in CLI authentication tests - #4514

Merged
cklin merged 3 commits into
mainfrom
copilot/investigate-cli-test-failure
Aug 13, 2026
Merged

Pin tutorial pack in CLI authentication tests#4514
cklin merged 3 commits into
mainfrom
copilot/investigate-cli-test-failure

Conversation

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Pins the authentication-test fixture to codeql/tutorial@0.0.11 so supported stable CLIs do not fail when the latest registry manifest changes. The test continues to cover credential prompting without acting as an unrelated floating registry compatibility test.

  • Pin the tutorial pack to a version supported by the CLI test matrix
  • Document why the pin exists and when it can be removed
  • Validate formatting and inspect the final diff
  • Confirm the PR's Linux and Windows CLI checks pass

Fixes #4510

Copilot AI linked an issue Aug 13, 2026 that may be closed by this pull request
@cklin

cklin commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@copilot Change this PR from an investigation PR to a fix PR that can be merged.

  • Update PR title and description to reflect this change in purpose
  • Add code comments to explain why the version pin exists, and under what conditions can the pin be removed

Co-authored-by: cklin <1418580+cklin@users.noreply.github.com>
@cklin cklin changed the title [WIP] Investigate CLI test failure and recommend repairs Pin tutorial pack in CLI authentication tests Aug 13, 2026

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Change this PR from an investigation PR to a fix PR that can be merged.

  • Update PR title and description to reflect this change in purpose
  • Add code comments to explain why the version pi...

Updated the PR title and description to present this as the mergeable fix, and documented the pin rationale and removal condition in commit 58e29b1.

@cklin
cklin marked this pull request as ready for review August 13, 2026 15:03
@cklin
cklin requested a review from a team as a code owner August 13, 2026 15:03
Copilot AI balanced review requested due to automatic review settings August 13, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the authentication fixture to a stable tutorial pack compatible with the CLI test matrix.

Changes:

  • Uses codeql/tutorial@0.0.11 in both authentication tests.
  • Documents why and when to remove the pin.
Show a summary per file
File Description
extensions/ql-vscode/test/vscode-tests/cli-integration/run-cli.test.ts Pins the authentication-test pack fixture and documents the rationale.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@cklin
cklin merged commit c702b10 into main Aug 13, 2026
33 checks passed
@cklin
cklin deleted the copilot/investigate-cli-test-failure branch August 13, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI test failure

4 participants