Skip to content

Pin tutorial pack in CLI authentication tests #4514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cklin merged 3 commits into from
Aug 13, 2026
Merged

Pin tutorial pack in CLI authentication tests #4514

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
856b880
Initial plan
Copilot Aug 13, 2026
ebf992c
Pin tutorial pack in CLI authentication tests
Copilot Aug 13, 2026
58e29b1
Document tutorial pack version pin
Copilot Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions extensions/ql-vscode/test/vscode-tests/cli-integration/run-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ describe("Use cli", () => {
},
);

// Pin this pack because these tests exercise authentication, not registry compatibility.
// Remove the pin once every supported CLI can download the latest tutorial pack.
describe("github authentication", () => {
itWithCodeQL()(
"should not use authentication if there are no credentials",
Expand All @@ -138,7 +140,7 @@ describe("Use cli", () => {
.spyOn(authentication, "getSession")
.mockResolvedValue(undefined);

await cli.packDownload(["codeql/tutorial"]);
await cli.packDownload(["codeql/tutorial@0.0.11"]);
expect(getSession).toHaveBeenCalledTimes(1);
expect(getSession).toHaveBeenCalledWith(
"github",
Expand All @@ -165,7 +167,7 @@ describe("Use cli", () => {
scopes: ["read:packages"],
});

await cli.packDownload(["codeql/tutorial"]);
await cli.packDownload(["codeql/tutorial@0.0.11"]);
expect(getSession).toHaveBeenCalledTimes(2);
expect(getSession).toHaveBeenCalledWith(
"github",
Expand Down